Skip to content

BI-2594 - Germplasm list table wrong when duplicate names are included#453

Merged
nickpalladino merged 3 commits intorelease/1.1from
bug/BI-2594
Apr 9, 2025
Merged

BI-2594 - Germplasm list table wrong when duplicate names are included#453
nickpalladino merged 3 commits intorelease/1.1from
bug/BI-2594

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Apr 8, 2025 •
edited by atlassian bot
Loading

Description

Story: BI-2594

  • Switched to using gids instead of germplasm names for tracking germplasm

Dependencies

  • release/1.1 bi-web

Testing

  • Import a germplasm file with duplicate names and pedigree. Verify that the germplasm list table shows the data in agreement with the file

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Apr 8, 2025
@nickpalladino nickpalladino changed the title BI-2594 BI-2594 - Germplasm list table wrong when duplicate names are included Apr 8, 2025
@nickpalladino nickpalladino marked this pull request as ready for review April 8, 2025 19:55
@nickpalladino nickpalladino requested review from a team, HMS17 and davedrp and removed request for a team April 8, 2025 19:55
HMS17
HMS17 reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, particularly like the documentation for the utility method

davedrp
davedrp requested changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed

@nickpalladino nickpalladino merged commit 88640ec into release/1.1 Apr 9, 2025
@nickpalladino nickpalladino deleted the bug/BI-2594 branch April 9, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HMS17 HMS17 HMS17 left review comments

@davedrp davedrp davedrp requested changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickpalladino @davedrp @HMS17