Skip to content

BI-2593 - Circular Dependency False Positive Error#452

Merged
nickpalladino merged 4 commits intorelease/1.1from
bug/BI-2593
Apr 9, 2025
Merged

BI-2593 - Circular Dependency False Positive Error#452
nickpalladino merged 4 commits intorelease/1.1from
bug/BI-2593

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Apr 7, 2025 •
edited by atlassian bot
Loading

Description

Story: BI-2593

  • Updated so that germplasm id references are unique for both preview and commit phases of postOrder

Dependencies

  • develop bi-web

Testing

  • Ensure that files with duplicate names and pedigree work and that there are no regressions. Example test file:

Pecan Import All Germplasm Renamed.xlsx

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Apr 7, 2025
@nickpalladino nickpalladino changed the title BI-2593 BI-2593 - Circular Dependency False Positive Error Apr 8, 2025
@nickpalladino nickpalladino marked this pull request as ready for review April 8, 2025 15:59
@nickpalladino nickpalladino requested review from davedrp and mlm483 April 8, 2025 16:03
@mlm483 mlm483 self-assigned this Apr 8, 2025
mlm483
mlm483 approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working. 🚀

I did notice that when uploading a file to create a germplasm list from germplasm already in the system (referencing existing GIDs), the preview shows correct male and female parent GIDs, but incorrect male and female parent entry numbers. Probably, no data should be shown in the male and female parent entry number fields in the case where you're uploading a file that contains GIDs.
Screenshot 2025-04-08 at 5 08 55 PM

I tested with develop, and observed the same issue, so it was not introduced by your changes.

@nickpalladino
Copy link
Member Author

nickpalladino commented Apr 9, 2025

Tested, working. 🚀

I did notice that when uploading a file to create a germplasm list from germplasm already in the system (referencing existing GIDs), the preview shows correct male and female parent GIDs, but incorrect male and female parent entry numbers. Probably, no data should be shown in the male and female parent entry number fields in the case where you're uploading a file that contains GIDs. Screenshot 2025-04-08 at 5 08 55 PM

I tested with develop, and observed the same issue, so it was not introduced by your changes.

I'll create a card for that

@nickpalladino nickpalladino merged commit 8c0ed22 into release/1.1 Apr 9, 2025
1 check passed
@nickpalladino nickpalladino deleted the bug/BI-2593 branch April 9, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davedrp davedrp davedrp approved these changes

@mlm483 mlm483 mlm483 approved these changes

Assignees

@mlm483 mlm483

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickpalladino @davedrp @mlm483