BI-2379 - Create Delete Endpoint for Deltabreed Sample Controller#440
Merged
nickpalladino merged 14 commits intodevelopfrom Feb 13, 2025
Merged
BI-2379 - Create Delete Endpoint for Deltabreed Sample Controller#440nickpalladino merged 14 commits intodevelopfrom
nickpalladino merged 14 commits intodevelopfrom
Conversation
mlm483
approved these changes
Feb 12, 2025
Contributor
mlm483
left a comment
There was a problem hiding this comment.
Tested, working. Approved, minor changes suggested.
| * Deletes the bidb submission record and BrAPI samples & plates | ||
| * @param programId bi-api id of program | ||
| * @param submissionId bi-api id of submission | ||
| * @return |
Contributor
There was a problem hiding this comment.
Specify return value or remove that line.
src/main/java/org/breedinginsight/services/SampleSubmissionService.java
Outdated
Show resolved
Hide resolved
…vice.java Co-authored-by: mlm483 <128052931+mlm483@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2379
Dependencies
Testing
Change submission status in UI as needed to test different acceptance criteria as listed below:
GIVEN a DELETE programs/{programId}/submissions/{submissionId} request
WHEN the sample submission specified has a submission status of NOT SUBMITTED
THEN the sample submission is deleted (submission, samples, and plates)
GIVEN a DELETE programs/{programId}/submissions/{submissionId} request
WHEN the sample specified has a submission status of SUBMITTED or COMPLETED regardless of hard query parameter value
THEN the sample is not deleted and an error code of 405 is returned.
GIVEN a submission has been deleted
WHEN a new submission with the same name as a previously deleted submission is created
THEN it should be created without error (names can be reused)
The UI component of this work is not yet completed so api calls will need to be made manually. The request URL will look like:
DELETE
http://localhost:8081/v1/programs/{programId}/submissions/{submissionId}The programId and submissionId values can be grabbed from the browser path when navigated to the submission in question.
Checklist: