Conversation
7 tasks
mlm483
approved these changes
Nov 21, 2024
davedrp
requested changes
Nov 22, 2024
Contributor
davedrp
left a comment
There was a problem hiding this comment.
FAILED TESTING.
Everything looks great and behaves perfectly. But, I did find one numeric column that has been overlooked.
If you navigate to Germplam > List > Details you’ll get something like:
The filter for Entry Number use the exact numerical match.
Contributor
Author
Added exact match for entry number |
davedrp
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2343 - GID filtering not informative
Changes to enable exact match GID filtering for multiple tables
For Experiment Details and Sample Submission Details tables, frontend search is used, so a custom-search function was added in the respective buefy files to do exact search filtering in the GID case.
For Germplasm and Germplasm list tables, backend search is used, which presently only does partial matching. Due to the high risk associated with modifying backend search to alternatively enable exact or partial match for each filter, ResponseUtils:search was slightly modified to do an exact match specifically when the filter is accessionNumber.
Dependencies
bi-web: bug/BI-2343
Testing
see bi-web
Checklist: