Conversation
also removed hard-coded transitive dependencies
nickpalladino
left a comment
There was a problem hiding this comment.
Was able to import traits without error
pom.xml
Outdated
| @@ -91,10 +91,9 @@ | |||
| <mockito.version>4.3.1</mockito.version> | |||
| <brapi-java-client.version>2.1-SNAPSHOT</brapi-java-client.version> | |||
| <commons-io.version>2.11.0</commons-io.version> | |||
There was a problem hiding this comment.
Is the commons-io.version needed?
There was a problem hiding this comment.
It was unnecessary, I removed it. Thanks.
| <artifactId>brapi-java-client</artifactId> | ||
| <version>${brapi-java-client.version}</version> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
I assume tika is pulling all these in?
There was a problem hiding this comment.
Yes, maven pulls those in to build tika as they are dependencies of tika. I don't know how common or advisable it is to hard-code transitive dependencies with maven projects, I used trial and error to determine that maven did the right thing for all the transitive dependencies besides apache commons compress, which I hard-coded. I think the issue might have been that two primary dependencies of bi-api both depend on apache commons compress, and maven was defaulting to using a version that didn't work with tika.
Description
Story: BI-2156
Testing
You may need to do a maven
clean install.Checklist: