Skip to content

[BI-2354] - Incorrect Case Sensitivity in Exp Import Error Message#420

Merged
mlm483 merged 1 commit intorelease/1.0from
bug/BI-2354
Nov 4, 2024
Merged

[BI-2354] - Incorrect Case Sensitivity in Exp Import Error Message#420
mlm483 merged 1 commit intorelease/1.0from
bug/BI-2354

Conversation

@mlm483
Copy link
Contributor

@mlm483 mlm483 commented Oct 30, 2024

Description

Story: https://breedinginsight.atlassian.net/browse/BI-2354

  • Made the code that collects invalid ontology terms for the error message do a case-insensitive contains (thanks Nick for the utility method).
  • Modified aforementioned containsCaseInsensitive utility method to work on any Collection<String> so I could use it on a Set<String> as well as a List<String>.
  • The second place I updated the code to be case-insensitive (in ExperimentProcessor.java) seems to be unused, but I updated the logic in case it is ever used again.

Testing

  1. Import germplasm: 100_germplasm_QUICK.csv.
  2. Import ontology: R2D2_Active_Ontology_2024-10-30_04-56-59+0000.xlsx.
  3. Try importing this experiment file before and after fixing the "Fry Colors" ontology term (should be "Fry Color"), with different casing: Exp_Error.xls. The error message should only list ontology terms that are misspelled, it should be case-insensitive. And when the misspelling is corrected, the ontology terms should be accepted with any casing.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Oct 30, 2024
@mlm483 mlm483 requested review from a team, HMS17 and dmeidlin and removed request for a team October 30, 2024 17:50
Copy link
Contributor

@dmeidlin dmeidlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass. Thanks for including the test files!

@mlm483 mlm483 merged commit 6862768 into release/1.0 Nov 4, 2024
@mlm483 mlm483 deleted the bug/BI-2354 branch November 4, 2024 16:23
@mlm483 mlm483 restored the bug/BI-2354 branch November 4, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants