Skip to content

BI-2328 Failed QA#417

Merged
davedrp merged 3 commits intorelease/1.0from
bug/BI-2328_fix
Oct 31, 2024
Merged

BI-2328 Failed QA#417
davedrp merged 3 commits intorelease/1.0from
bug/BI-2328_fix

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented Oct 28, 2024

Description

BI-2328 Experimental observation file import removes periods from column headers

The previous pull request passed but was branched off of the 'develop' branch instead of the 'release/1.0' branch. This PR fixes that.

Dependencies

bi-web: bug/BI-2328

Testing

See the previous pull request

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@davedrp davedrp requested review from a team, HMS17 and dmeidlin and removed request for a team October 28, 2024 18:01
@github-actions github-actions bot added the bug Something isn't working label Oct 28, 2024
@mlm483 mlm483 self-requested a review October 31, 2024 14:39
@mlm483 mlm483 self-assigned this Oct 31, 2024
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working.

@davedrp davedrp merged commit c9bc45f into release/1.0 Oct 31, 2024
@davedrp davedrp deleted the bug/BI-2328_fix branch October 31, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants