Skip to content

BI-2338 - Germplasm file with problems is loading, but preventing download#416

Merged
mlm483 merged 1 commit intorelease/1.0from
bug/BI-2338
Nov 4, 2024
Merged

BI-2338 - Germplasm file with problems is loading, but preventing download#416
mlm483 merged 1 commit intorelease/1.0from
bug/BI-2338

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Oct 23, 2024

Description

Story: BI-2338

  • Trim values in Excel file import flow

An additional card was made for inclusion in a post MVP release to either not allow '[]' in germplasm names or only strip off the rightmost occurrence of them from names.

Dependencies

  • None

Testing

  • Ensure Germplasm import file with germplasm names containing trailing whitespace can be imported and downloaded without issue

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Oct 23, 2024
@nickpalladino nickpalladino changed the title Trim values in excel flow BI-2338 - Germplasm file with problems is loading, but preventing download Oct 23, 2024
@nickpalladino nickpalladino requested review from a team, davedrp and dmeidlin and removed request for a team October 23, 2024 19:19
@davedrp davedrp self-assigned this Oct 28, 2024
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Developer testing.

Code looks good

@mlm483 mlm483 merged commit c09857c into release/1.0 Nov 4, 2024
@mlm483 mlm483 deleted the bug/BI-2338 branch November 4, 2024 17:29
@mlm483 mlm483 restored the bug/BI-2338 branch November 4, 2024 17:30
@mlm483 mlm483 deleted the bug/BI-2338 branch November 4, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants