BI-2330 - MrBean DeltaBreed Integration#413
Merged
mlm483 merged 13 commits intorelease/1.0from Oct 28, 2024
Merged
Conversation
Mr. Bean integration working
src/main/java/org/breedinginsight/brapi/v2/model/request/query/ObservationQuery.java
Outdated
Show resolved
Hide resolved
| .observationUnitLevelRelationshipCode(observationUnitLevelRelationshipCode); | ||
| } | ||
|
|
||
| public SearchRequest constructSearchRequest() { |
Member
There was a problem hiding this comment.
Was this and the next method just left in for potential future use in case we switch to using cache data or a different proxying method?
Contributor
Author
There was a problem hiding this comment.
Yes, both constructSearchRequest and toQueryString were used in different implementations I was experimenting with. They might be useful in the future, but I'm in favor of removing unused code... what do you think?
nickpalladino
approved these changes
Oct 23, 2024
This was referenced Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-2330
The observations/table endpoint was not implemented. This PR implements it as a proxy request to the backing BrAPI service with id translation for the only parameter that Mr. Bean seems to use,
studyDbId.Dependencies
For testing, Breeding Insight's fork of Mr. Bean: https://github.com/Breeding-Insight/MrBeanApp
Testing
If the observations are loaded without error, then the observations/table endpoint is working!
You can also try testing the endpoint manually, it's a GET request to /brapi/v2/observations/table.
Checklist: