Skip to content

BI-2306 - Helium BrAPI integration filter by accessionNumber #412

Merged
nickpalladino merged 1 commit intorelease/1.0from
bug/BI-2306
Oct 15, 2024
Merged

BI-2306 - Helium BrAPI integration filter by accessionNumber #412
nickpalladino merged 1 commit intorelease/1.0from
bug/BI-2306

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Oct 9, 2024 •
edited by atlassian bot
Loading

Description

Story: BI-2306

  • Added query parameter for accessionNumber

Dependencies

  • None

Testing

  • Load data in Helium (https://helium.hutton.ac.uk) via BrAPI and filter by accessionNumber
    • Verify get data for that germplasm and loading time is acceptable in program with large amount of germplasm

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@nickpalladino nickpalladino requested review from a team, HMS17 and davedrp and removed request for a team October 9, 2024 20:36
@github-actions github-actions bot added the bug Something isn't working label Oct 9, 2024
HMS17
HMS17 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, locally created program with thousands of germplasm, went into helium and filtered by accession number and selected include full tree, pedigree tree took 9 seconds to create.

@nickpalladino nickpalladino merged commit 3d8c685 into release/1.0 Oct 15, 2024
@nickpalladino nickpalladino deleted the bug/BI-2306 branch October 15, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davedrp davedrp davedrp approved these changes

@HMS17 HMS17 HMS17 approved these changes

Assignees

@HMS17 HMS17

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickpalladino @davedrp @HMS17