Skip to content

[BI-2203] Insert sandbox email into bi_user table#408

Merged
davedrp merged 6 commits intodevelopfrom
bug/BI-2203
Oct 10, 2024
Merged

[BI-2203] Insert sandbox email into bi_user table#408
davedrp merged 6 commits intodevelopfrom
bug/BI-2203

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented Sep 27, 2024

Description

BI-2203 Insert sandbox email into bi_user table

Please include a summary of the change that was made.

  • Created 2 migrations
  1. A java migration to populate the email of the "BI-DEV Admin" user (based on whether it should be authorized with sandbox Orcid or the production Orcid).
  2. A migration to add a constraint on the bi_user table (that prevents the orcid id from being non-null if the email is null).
  • Added a configuration variable (ORCID_SANDBOX_AUTHENTICATION) that is true if the Oricid Sandbox should be used, and false infthe production Orcid should be used.

Testing

  • verify that the migration inserts the address in the table
  • sign in to Deltabreed with sys admin permissions and add a new user to the system with bidevteam@mailinator.com as the address and confirm that this is prevented and an error message is returned saying that a user with that address already exists.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@davedrp davedrp requested review from a team, HMS17 and dmeidlin and removed request for a team September 27, 2024 20:05
@github-actions github-actions bot added the bug Something isn't working label Sep 27, 2024
@davedrp davedrp merged commit 011f006 into develop Oct 10, 2024
@davedrp davedrp deleted the bug/BI-2203 branch October 10, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants