[BI-2067] - Merge FieldBook BrAPI program endpoint with Mr.Bean work#407
Merged
[BI-2067] - Merge FieldBook BrAPI program endpoint with Mr.Bean work#407
Conversation
mlm483
approved these changes
Oct 1, 2024
nickpalladino
requested changes
Oct 1, 2024
|
|
||
| //If programId supplied, check if program exists | ||
| if (programId != null) { | ||
| Optional<Program> optProgram = programService.getById(programId); |
Member
There was a problem hiding this comment.
I think this optional could be reused below to get the program rather than calling programService.getById again. Also, if programId were null the programService.getById below would be called with the null programId based on the current check.
BI-2308 - Field Book BrAPI Integration - Importing Fields release/1.0 merge
nickpalladino
approved these changes
Oct 7, 2024
BI-2304 - merging into release/1.0
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2067 - Merge Tim's FieldBook BrAPI program endpoint with Mr.Bean work
Dependencies
n/a
Testing
Test that Mr. Bean and Fieldbook functionality related to programs endpoint still works as expected
Checklist: