Description

BI-2267 Trim trailing white space on breeding method file uploads (FAILED QA)

THE BUG caused by the new code for BI-2267

IF the he Breeding Method field in the germplasm import file has the value "Bulk or population " (with a trailing blank),
THEN the import fails with an erroneous "Invalid Breeding Method" error.

BACKGROUND

• The Breeding Method field in the germplasm import file must match the name column in the breeding_method table exactly.
• One entry in the breeding_method table has a trailing blank in the name column; "Bulk or population ".
• The new code for BI-2267 trims the white space off of the value for the Breeding Method field in the germplasm import file.
• this causes an erroneous "Invalid Breeding Method" error (because "Bulk or population" <> "Bulk or population ").

Solution

Two fixes were made. Either one would fix the immediate problem, but both solutions are present for completeness and to prevent future problems.

1. A migration was added to remove the trailing space in the breeding_method table.
2. The lookup code for the name column in the breeding_method table, now includes DSL.trim().

Dependencies

bi-web: develop

Testing

• import the germplasm file bi_germplasm_import_template_v11(2).xls

Expected Result
It should import without errors.

Checklist:

• I have performed a self-review of my own code
• I have tested my code and ensured it meets the acceptance criteria of the story
• I have tested that my code works with both the brapi-java-server and BreedBase
• I have create/modified unit tests to cover this change
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to documentation
• I have run TAF: <please include a link to TAF run>