Skip to content

BI-2274 - BrAPI germplasm search response incorrect#397

Merged
nickpalladino merged 6 commits intodevelopfrom
bug/BI-2274
Sep 19, 2024
Merged

BI-2274 - BrAPI germplasm search response incorrect#397
nickpalladino merged 6 commits intodevelopfrom
bug/BI-2274

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Sep 3, 2024

Description

Story: BI-2274

  • Changed /search/germplasm endpoint to pass through to BrAPI server and add DeltaBreed program UUID to externalReferences filter so we only get back germplasm for the program in question
  • Disabled failing integration tests as they were using old non-brapi compliant body

Dependencies

  • None

Testing

  • API testing to ensure endpoint works for both immediate and searchResultId cases
    • Field Book integration will not fully work and should not be tested until all the stories linked in BI-2308 are completed

NOTE: During testing an issue was found with the BrAPI test server when pageSize is specified as totalCount or more, an empty data array is returned even though there should be records. If necessary for Field Book integration this will be addressed as part of BI-2308.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Sep 3, 2024
@nickpalladino nickpalladino changed the title Started migrating /search/germplasm to be compliant with brapi spec BI-2274 - BrAPI germplasm search response incorrect Sep 3, 2024
@nickpalladino nickpalladino marked this pull request as ready for review September 11, 2024 17:28
@nickpalladino nickpalladino requested review from a team, HMS17 and davedrp and removed request for a team September 11, 2024 17:29
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Developer test

@nickpalladino nickpalladino merged commit 1dc88cc into develop Sep 19, 2024
@nickpalladino nickpalladino deleted the bug/BI-2274 branch September 19, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants