Skip to content

BI-2266 - use GID as Entry No for all germplasm export#395

Merged
mlm483 merged 3 commits intodevelopfrom
bug/BI-2266
Aug 29, 2024
Merged

BI-2266 - use GID as Entry No for all germplasm export#395
mlm483 merged 3 commits intodevelopfrom
bug/BI-2266

Conversation

@mlm483
Copy link
Contributor

@mlm483 mlm483 commented Aug 27, 2024

Description

Story: BI-2266

The file exported through the "Download file" action on the all germplasm list view contains all germplasm in the program. When multiple germplasm lists have been uploaded, BI-2266 specifies the desired behavior is for the "Entry No" column to contain the GID (instead of a list entry number from whatever list the germplasm was originally uploaded in, which was the previous behavior).

Testing

  1. Upload multiple germplasm lists to a program.
  2. Download all germplasm, ensure "Entry No" matches GID for all rows.
  3. Download individual germplasm lists, ensure "Entry No" matches import entry number.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@mlm483 mlm483 changed the title [BI-2266] - use GID as Entry No for all germplasm export BI-2266 - use GID as Entry No for all germplasm export Aug 27, 2024
@github-actions github-actions bot added the bug Something isn't working label Aug 27, 2024
@mlm483 mlm483 marked this pull request as ready for review August 27, 2024 19:31
@mlm483 mlm483 requested review from a team, davedrp and nickpalladino and removed request for a team August 27, 2024 21:20
@mlm483 mlm483 merged commit 17ac899 into develop Aug 29, 2024
@mlm483 mlm483 deleted the bug/BI-2266 branch August 29, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants