Skip to content

BI-2227 - Modify Upload Experiment and Observations File to accept without sub units#394

Merged
nickpalladino merged 6 commits intodevelopfrom
feature/BI-2227
Aug 27, 2024
Merged

BI-2227 - Modify Upload Experiment and Observations File to accept without sub units#394
nickpalladino merged 6 commits intodevelopfrom
feature/BI-2227

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Aug 22, 2024 •
edited
Loading

Description

Story: BI-2227

  • db migration to remove subentity columns from exp import template

Dependencies

Testing

  • Get error when old subentity columns are included
  • Using new template without subentity columns should import without issue

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@nickpalladino nickpalladino changed the title db migration to remove subentity columns from exp import template BI-2227 - Modify Upload Experiment and Observations File to accept without sub units Aug 22, 2024
@nickpalladino nickpalladino requested review from a team, dmeidlin and mlm483 and removed request for a team August 22, 2024 17:48
@nickpalladino nickpalladino marked this pull request as ready for review August 22, 2024 19:34
@nickpalladino
Copy link
Member Author

nickpalladino commented Aug 22, 2024

Looks like I need to fix some tests

@mlm483 mlm483 requested review from HMS17 and removed request for mlm483 August 26, 2024 15:12
@nickpalladino
Copy link
Member Author

nickpalladino commented Aug 26, 2024

tests fixed

@HMS17 HMS17 self-assigned this Aug 26, 2024
HMS17
HMS17 requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BI-2283 uses V1.27.0 for its migration V1.27.0__fix_fk_constraint.sql, so the migration number would need to be changed here

@nickpalladino nickpalladino requested a review from HMS17 August 26, 2024 21:01
@nickpalladino
Copy link
Member Author

nickpalladino commented Aug 26, 2024

@HMS17 Renamed migration

HMS17
HMS17 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed test!

@nickpalladino nickpalladino merged commit c6d1f77 into develop Aug 27, 2024
@nickpalladino nickpalladino deleted the feature/BI-2227 branch August 27, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmeidlin dmeidlin dmeidlin approved these changes

@HMS17 HMS17 HMS17 approved these changes

Assignees

@HMS17 HMS17

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickpalladino @dmeidlin @HMS17