[BI-2267] Trim trailing white space on breeding method file uploads#392
Merged
[BI-2267] Trim trailing white space on breeding method file uploads#392
Conversation
mlm483
approved these changes
Aug 21, 2024
Contributor
mlm483
left a comment
There was a problem hiding this comment.
I wonder if the meaning of trimBreedingMethod or stripBreedingMethod would be more clear than "remove...blanks" to developers. What do you think?
I think it was decided that the scope of this bug would remain narrow, so I'm fine with it only being for the breeding method. If we want to refactor the method to strip/trim more fields in the future it won't be hard to do. In that vein... you could name the method more generically like stripWhitespace. I'm happy either way.
dmeidlin
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BI-2267 Trim trailing white space on breeding method file uploads
Description
When importing germplasm, if there was a trailing blank in a breeding method value, then the system was generating the table error
Invalid breeding method.This fix removes any leading and trailing spaces in the imported breeding method values.
Dependencies
Please include any dependencies to other code branches, testing configurations, scripts to be run, etc.
Testing
EXPECTED RESULT
There should be no Table Error
Invalid breeding methodChecklist: