[BI-2256] - Experimental Collaborator BI-API Changes#390
Merged
nickpalladino merged 35 commits intodevelopfrom Aug 29, 2024
Merged
[BI-2256] - Experimental Collaborator BI-API Changes#390nickpalladino merged 35 commits intodevelopfrom
nickpalladino merged 35 commits intodevelopfrom
Conversation
…-2256 # Conflicts: # src/main/java/org/breedinginsight/api/model/v1/request/ExperimentCollaboratorRequest.java # src/main/java/org/breedinginsight/api/model/v1/response/ExperimentalCollaboratorResponse.java # src/main/java/org/breedinginsight/api/v1/controller/ExperimentController.java # src/test/java/org/breedinginsight/brapi/v2/ExperimentControllerIntegrationTest.java
mlm483
approved these changes
Aug 26, 2024
Contributor
mlm483
left a comment
There was a problem hiding this comment.
Tested the endpoints with Bruno, working. 🚀
Contributor
There was a problem hiding this comment.
This is an improvement, thanks!
dmeidlin
requested changes
Aug 26, 2024
Contributor
dmeidlin
left a comment
There was a problem hiding this comment.
The ExperimentController provides non-BrAPI endpoints and resides in /api/v1/controller;
however, the ExperimentControllerIntegrationTest resides in /brapi/v2/. For consistency, the test class should be moved to /test/java/org/breedinginsight/api/v1/controller.
Contributor
Good catch, change made |
dmeidlin
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2256 - Experimental Collaborator BI-API Changes
Added POST, GET, and DELETE Experimental Collaborator Controller Methods to ExperimentalController.Java
Added Models for ExperimentalCollaboratorRequest and ExperimentalCollaboratorResponse to assist in controller methods
Added getRoleByDomain method to RoleService to assist in controller methods
Modified some naming of variables in existing Experimental Collaborator methods for the sake of clarity
Added Experimental Collaborator Unit Tests
Dependencies
n/a
Testing
Backend changes, only can test HTTP endpoint calls and added unit tests
Checklist: