Skip to content

BI-2134 GeoGson Type Adapter Bug#389

Merged
dmeidlin merged 1 commit intodevelopfrom
bug/BI-2134-geogson
Aug 15, 2024
Merged

BI-2134 GeoGson Type Adapter Bug#389
dmeidlin merged 1 commit intodevelopfrom
bug/BI-2134-geogson

Conversation

@dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Aug 13, 2024

Description

Story: BI-2134

The cloning of entities via serializing-deserializing with Gson was producing an error if the instance being cloned contained nested classes that use the geogson library. The geometry type adapter was specified when building the gson instances to fix the error.

Dependencies

none

Testing

same test procedure as BI-2134

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Aug 13, 2024
@dmeidlin dmeidlin requested review from a team, HMS17 and davedrp and removed request for a team August 13, 2024 23:19
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed test.
Looks good

@dmeidlin dmeidlin merged commit 6fdec7f into develop Aug 15, 2024
@dmeidlin dmeidlin deleted the bug/BI-2134-geogson branch August 15, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants