Skip to content

fix error message for missing obs unit id#384

Merged
dmeidlin merged 1 commit intodevelopfrom
bug/BI-2134
Aug 7, 2024
Merged

fix error message for missing obs unit id#384
dmeidlin merged 1 commit intodevelopfrom
bug/BI-2134

Conversation

@dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Aug 7, 2024

Description

Story: BI-2134

The error message for the case of missing obs-unit ids for append workflow was changed to match the source of truth. A bug in writing the error message was fixed.

Dependencies

bi-web:develop

Testing

  1. create an experiment
  2. download experiment data
  3. append data to the experiment download
  4. delete one or more ids from the obs-unit-id column
  5. import appended data
  6. confirm the red error banner in the UI states "Required field is blank"

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@dmeidlin dmeidlin requested review from a team, HMS17 and davedrp and removed request for a team August 7, 2024 13:35
@github-actions github-actions bot added the bug Something isn't working label Aug 7, 2024
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes the test criteria.

@dmeidlin dmeidlin merged commit 8a3fa22 into develop Aug 7, 2024
@dmeidlin dmeidlin deleted the bug/BI-2134 branch August 7, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants