Skip to content

BI-2254 - Experimental Collaborator DB Changes#382

Merged
nickpalladino merged 6 commits intodevelopfrom
feature/BI-2254
Jul 29, 2024
Merged

BI-2254 - Experimental Collaborator DB Changes#382
nickpalladino merged 6 commits intodevelopfrom
feature/BI-2254

Conversation

@mlm483
Copy link
Contributor

@mlm483 mlm483 commented Jul 25, 2024

Description

Story: https://breedinginsight.atlassian.net/browse/BI-2254

  • Added migrations to add the Experimental Collaborator role and to add the experiment_program_user_role table.
  • Added EXPERIMENTAL_COLLABORATOR to the ProgramSecuredRole enum.
  • Added ExperimentalCollaboratorDAO and ExperimentalCollaboratorService, they are empty and will be implemented fully in BI-2257.
    • ExperimentalCollaboratorDAO extends ExperimentProgramUserRoleDao, which is the jooq generated DAO for the experiment_program_user_role table. If the methods available on the base DAO are sufficient, then the main benefit of ExperimentalCollaboratorDAO is its name, but if we need to implement custom data access methods, they can be done using the jooq DSLContext injected into ExperimentalCollaboratorDAO.

Dependencies

Testing

  1. To get migrations to run and jooq to generate the new classes, you may need to do a clean install.
  2. Log in to DeltaBreed as a System Administrator and add a new user to a program with the "Experimental Collaborator" role.
  3. [Optional] Use the email address "devtest@mailinator.com" for this user and use the associated shared ORCID creds in LastPass if you want to test logging in with this user (you will hit an Unauthorized page).

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@mlm483 mlm483 requested review from a team, davedrp and nickpalladino and removed request for a team July 26, 2024 15:29
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Developer Testing

Copy link
Member

@nickpalladino nickpalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing headers to a couple files

@nickpalladino nickpalladino merged commit 36faf6d into develop Jul 29, 2024
@nickpalladino nickpalladino deleted the feature/BI-2254 branch July 29, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants