BI-2254 - Experimental Collaborator DB Changes#382
Merged
nickpalladino merged 6 commits intodevelopfrom Jul 29, 2024
Merged
Conversation
davedrp
approved these changes
Jul 26, 2024
Contributor
davedrp
left a comment
There was a problem hiding this comment.
Passed Developer Testing
nickpalladino
approved these changes
Jul 29, 2024
Member
nickpalladino
left a comment
There was a problem hiding this comment.
Added missing headers to a couple files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-2254
Experimental Collaboratorrole and to add theexperiment_program_user_roletable.EXPERIMENTAL_COLLABORATORto theProgramSecuredRoleenum.ExperimentalCollaboratorDAOandExperimentalCollaboratorService, they are empty and will be implemented fully in BI-2257.ExperimentalCollaboratorDAOextendsExperimentProgramUserRoleDao, which is the jooq generated DAO for the experiment_program_user_role table. If the methods available on the base DAO are sufficient, then the main benefit ofExperimentalCollaboratorDAOis its name, but if we need to implement custom data access methods, they can be done using the jooqDSLContextinjected intoExperimentalCollaboratorDAO.Dependencies
Testing
clean install.Checklist: