Skip to content

BI-2163 QA Failure#381

Merged
nickpalladino merged 1 commit intodevelopfrom
feature/BI-2163-2
Jul 29, 2024
Merged

BI-2163 QA Failure#381
nickpalladino merged 1 commit intodevelopfrom
feature/BI-2163-2

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Jul 24, 2024 •
edited
Loading

Description

Story: BI-2163

  • Added species to brapi server that were missing

Dependencies

  • None

Testing

  • Create a program using one of the new species from the program creation page, make sure it creates it without error

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@nickpalladino nickpalladino marked this pull request as ready for review July 25, 2024 15:42
@nickpalladino nickpalladino requested review from HMS17 and mlm483 July 25, 2024 15:42
@mlm483 mlm483 self-assigned this Jul 25, 2024
mlm483
mlm483 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working.

@nickpalladino nickpalladino requested review from davedrp and removed request for HMS17 July 25, 2024 18:57
@nickpalladino nickpalladino merged commit 9e5750d into develop Jul 29, 2024
@nickpalladino nickpalladino deleted the feature/BI-2163-2 branch July 29, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davedrp davedrp davedrp approved these changes

@mlm483 mlm483 mlm483 approved these changes

Assignees

@mlm483 mlm483

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickpalladino @davedrp @mlm483