Skip to content

BI-2132 Failed QA#375

Merged
nickpalladino merged 28 commits intodevelopfrom
bug/BI-2115
Jul 24, 2024
Merged

BI-2132 Failed QA#375
nickpalladino merged 28 commits intodevelopfrom
bug/BI-2115

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Jul 16, 2024 •
edited
Loading

Description

Story: BI-2132

  • Merge latest changes from BI-2132-A into BI-2115
  • Fix tests for workflow updates

Dependencies

Testing

Please include any details needed for reviewers to test this code

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

dmeidlin and others added 23 commits June 11, 2024 11:47
@dmeidlin
Merge pull request #360 from Breeding-Insight/feature/BI-2122-A
d21a988 
[BI-2122-A] Workflows Select
@nickpalladino
Merge branch 'feature/BI-2122' into feature/BI-2132-A
e406e38
@nickpalladino
Messing with dependency issue
79189ba
@nickpalladino
Removed ununsed fileImportService injection and resolved DI issue
0ef8cd5
@nickpalladino
Added in BI-2128 change
1acd04b
@nickpalladino
Merge branch 'develop' into feature/BI-2132-A
fc2a661
@nickpalladino
Updated create only tests to use create workflow
6a4043d
@nickpalladino
Removed unused migration
651cffc
@nickpalladino
Removed append environment workflow
39fb8cd
@nickpalladino
Fix error message
be8ea38
@nickpalladino
Removed navigator stuff handled in domain import service
d11ef3c
@nickpalladino
Removed some development comments
eebb493
@nickpalladino
Reference enum for new-experiment
b5dc3e8
@nickpalladino @mlm483
Change variable name to reflect string type
2bbf7f3 
Co-authored-by: mlm483 <128052931+mlm483@users.noreply.github.com>
@nickpalladino
Clarified comment
ccc1414
@nickpalladino
Clarified comment
7a35165
@nickpalladino
Removed old comment
aa06c6e
@nickpalladino
Updated doc comment
dd6f348
@nickpalladino
Cleaned up ProcessedData code
a6c3590
@nickpalladino
Changed from workflow to workflowId
1a6de32
@nickpalladino
Change exception handling
a488612
@nickpalladino
Merge branch 'develop' into feature/BI-2132-A
9b04d44
@nickpalladino
Merge branch 'feature/BI-2132-A' into bug/BI-2115
c9ed7d0
@github-actions github-actions bot added the bug Something isn't working label Jul 16, 2024
@nickpalladino nickpalladino changed the title Bug/bi 2115 BI-2132 Failed QA Jul 19, 2024
@nickpalladino nickpalladino marked this pull request as ready for review July 22, 2024 13:53
@nickpalladino nickpalladino requested review from dmeidlin and mlm483 July 22, 2024 14:07
mlm483
mlm483 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working.

@nickpalladino nickpalladino merged commit 0573744 into develop Jul 24, 2024
@nickpalladino nickpalladino deleted the bug/BI-2115 branch July 24, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmeidlin dmeidlin dmeidlin approved these changes

@mlm483 mlm483 mlm483 approved these changes

Assignees

@mlm483 mlm483

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickpalladino @dmeidlin @mlm483