Skip to content

[BI-2104] Can't create experiment with timestamped observations#354

Merged
davedrp merged 1 commit intodevelopfrom
bug/BI-2104
May 2, 2024
Merged

[BI-2104] Can't create experiment with timestamped observations#354
davedrp merged 1 commit intodevelopfrom
bug/BI-2104

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented May 1, 2024

Description

BI-2104 - Can't create experiment with timestamped observations v0.9

There was a null pointer exception thrown in ExperimentProcessor.java at the line:
priorStamp = existingObsByObsHash.get(observationHash).getObservationTimeStamp()

Testing

Import a new experiment with observations (least one observation will need to have an associated time-stamp)

Expected Result

  • Experiment should import sucessfully.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@davedrp davedrp requested review from a team, dmeidlin and nickpalladino and removed request for a team May 1, 2024 13:23
@github-actions github-actions bot added the bug Something isn't working label May 1, 2024
@davedrp davedrp merged commit 9375820 into develop May 2, 2024
@davedrp davedrp deleted the bug/BI-2104 branch May 2, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants