BI-2101 - Configure Transactional Email for Production DeltaBreed#351
Merged
BI-2101 - Configure Transactional Email for Production DeltaBreed#351
Conversation
enabled direct SMTP connection to SES provided the correct authentication environment variables are present
Member
nickpalladino
left a comment
There was a problem hiding this comment.
Maybe the .env.template files here and in bi-docker-stack should have the new envs added
| props.put("mail.debug", true); | ||
| return Session.getInstance(props, null); | ||
| Authenticator auth = null; | ||
| if (Utilities.isNeitherNullNorEmpty(smtpLogin) && Utilities.isNeitherNullNorEmpty(smtpPassword)) { |
Member
There was a problem hiding this comment.
I think you could use StringUtils.isNotBlank from apache commons if you wanted to use an existing implementation.
nickpalladino
approved these changes
Apr 30, 2024
Contributor
Author
|
Thanks for the suggestion @nickpalladino, I opened a PR on bi-docker-stack here. |
dmeidlin
approved these changes
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-2101
This PR enables bi-api to send transactional email using SMTP provided the
EMAIL_RELAY_HOST,EMAIL_RELAY_PORT,EMAIL_RELAY_LOGINandEMAIL_RELAY_PASSWORDare provided.I configured DKIM and DMARC records required by SES so that we can send emails from noreply@breedinginsight.org.
I added an item to the v0.10 Deploy Checklist to update the production environment variables.
If the
EMAIL_RELAY_LOGINandEMAIL_RELAY_PASSWORDvariables are omitted or empty, the code will continue to use SMTP without auth, which is desirable in development and non-production deployments.Background Information
Dependencies
bi-web
developbranchTesting
Regression Testing
Feature Functional Testing
Checklist: