BI-2058 - Add Observations and ObservationUnits to Redis Cache#339
Merged
BI-2058 - Add Observations and ObservationUnits to Redis Cache#339
Conversation
IntelliJ was complaining
dmeidlin
approved these changes
Apr 4, 2024
davedrp
approved these changes
Apr 4, 2024
Contributor
davedrp
left a comment
There was a problem hiding this comment.
Passed Developer Testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-2058
Added Observations and ObservationUnits to the redis cache. They are eagerly fetched on application startup just like the other entities we cache.
All the methods that write Observations or ObservationUnits have been modified to repopulate the cache, which is essential for reading one's own writes.
Most of the methods that read Observations and Observation units have been modified to read from the cache.
Also, calling
ProgramCache::postwith a nullpostFunctionwould result in a NPE, I prevented this possibility, see this commit.Dependencies
bi-web develop branch
Testing
Ensure experiment upload, view, and download (file export) workflows work as expected.
Checklist: