[BI-2064] Invalid message if required data is missing #334
Merged
davedrp merged 2 commits intorelease/0.9from Mar 12, 2024
Merged
[BI-2064] Invalid message if required data is missing #334davedrp merged 2 commits intorelease/0.9from
davedrp merged 2 commits intorelease/0.9from
Conversation
…-poiner-exception
nickpalladino
approved these changes
Feb 21, 2024
Member
nickpalladino
left a comment
There was a problem hiding this comment.
Curious to see how this interacts with BI-2046 if that uses only ObsUnitIDs for overwrites
mlm483
requested changes
Feb 21, 2024
Contributor
mlm483
left a comment
There was a problem hiding this comment.
The missing env produced the desired error, however I got an unknown error banner for the missing year. In bi-api logs:
ERROR o.b.b.i.services.FileImportService - null
java.lang.NumberFormatException: null
at java.base/java.lang.Integer.parseInt(Integer.java:620)
at java.base/java.lang.Integer.parseInt(Integer.java:776)
at org.breedinginsight.brapps.importer.services.processors.ExperimentProcessor.yearToSeasonDbIdFromDatabase(ExperimentProcessor.java:1827)
at org.breedinginsight.brapps.importer.services.processors.ExperimentProcessor.yearToSeasonDbId(ExperimentProcessor.java:1797)
at org.breedinginsight.brapps.importer.services.processors.ExperimentProcessor.initNewBrapiData(ExperimentProcessor.java:560)
at org.breedinginsight.brapps.importer.services.processors.ExperimentProcessor.process(ExperimentProcessor.java:233)
at org.breedinginsight.brapps.importer.services.processors.ProcessorManager.process(ProcessorManager.java:63)
at org.breedinginsight.brapps.importer.model.imports.experimentObservation.ExperimentImportService.process(ExperimentImportService.java:74)
at org.breedinginsight.brapps.importer.services.FileImportService.lambda$processFile$9(FileImportService.java:427)I think it may be important to test the missing year upload in a fresh program with no existing season data to reproduce, just a hunch.
Contributor
|
@davedrp I'm still seeing that issue, here are the steps to reproduce.
You'll see "Unknown Error" on the frontend and the following error in bi-api logs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BI-2064 Invalid message if required data is missing
Not conforming
Dependencies
bi-web: release/0.9
Testing
see Acceptance Criteriain the Jirra Ticket
Checklist: