BI-2045 (Failure to report error when uploading duplicated experiment name)#333
Merged
davedrp merged 7 commits intorelease/0.9from Mar 5, 2024
Merged
BI-2045 (Failure to report error when uploading duplicated experiment name)#333davedrp merged 7 commits intorelease/0.9from
davedrp merged 7 commits intorelease/0.9from
Conversation
dmeidlin
approved these changes
Feb 20, 2024
Contributor
Author
|
Please Re-review. There were two things that have been fixed since this PR was approved.
|
dmeidlin
reviewed
Mar 4, 2024
src/main/java/org/breedinginsight/brapps/importer/services/processors/ExperimentProcessor.java
Outdated
Show resolved
Hide resolved
dmeidlin
reviewed
Mar 4, 2024
| @Test | ||
| @SneakyThrows | ||
| public void importNewExpMultiNewEnvNoObsSuccess() { | ||
| public void importNewExpMultiNewEnvError() { |
Contributor
There was a problem hiding this comment.
This test asserts that both environments import successfully, so it's not clear to me why the test name needs to change to include "Error".
dmeidlin
requested changes
Mar 4, 2024
Contributor
dmeidlin
left a comment
There was a problem hiding this comment.
Just a couple of small points, otherwise looks good.
mlm483
approved these changes
Mar 4, 2024
src/test/java/org/breedinginsight/brapps/importer/ExperimentFileImportTest.java
Show resolved
Hide resolved
dmeidlin
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BI-2045 (Failure to report error when uploading duplicated experiment name)
Dependencies
Please include any dependencies to other code branches, testing configurations, scripts to be run, etc.
Testing
Successfully import an experiment.
Attempt to import the same experiment file (with no ObsUnitIDs).
EXPECTED RESULT
Error detected in file, XXX.xls. Experiment Title already exists. Import cannot proceed.Checklist: