Conversation
950afc0 to
be777eb
Compare
dmeidlin
approved these changes
Mar 4, 2024
davedrp
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1993 - Accept NA Observations
Enables import of NA observations. Previously "NA" observations were set to blank on import due to default tablesaw behavior and "na" observations would be marked as invalid by validations for certain observation types.
Modify experiment import processing to skip observation ontology validations in the case where the entry is NA (case insensitive).
Modify pom/etc to utilize BI branch of tablesaw.
Dependencies
This utilizes a BI fork of tablesaw created as a consequence of this card due to the need to remove NA from the inbuilt missingValueString list that automatically converts cells with values on the list to empty cells.
Testing
Create an experiment and multiple types of ontology terms
Import observations for different ontology term types with the following observation values:
Checklist: