Skip to content

[BI-1993] - Accept NA observations#330

Merged
HMS17 merged 2 commits intodevelopfrom
feature/BI-1993
Mar 6, 2024
Merged

[BI-1993] - Accept NA observations#330
HMS17 merged 2 commits intodevelopfrom
feature/BI-1993

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Feb 7, 2024

Description

Story: BI-1993 - Accept NA Observations

Enables import of NA observations. Previously "NA" observations were set to blank on import due to default tablesaw behavior and "na" observations would be marked as invalid by validations for certain observation types.

Modify experiment import processing to skip observation ontology validations in the case where the entry is NA (case insensitive).

Modify pom/etc to utilize BI branch of tablesaw.

Dependencies

This utilizes a BI fork of tablesaw created as a consequence of this card due to the need to remove NA from the inbuilt missingValueString list that automatically converts cells with values on the list to empty cells.

Testing

Create an experiment and multiple types of ontology terms
Import observations for different ontology term types with the following observation values:

  • Valid value (should be displayed correctly on import and be imported properly)
  • Invalid value (should get an error)
  • NA (should be NA on import and be imported properly)
  • na (should be na on import and be imported properly)
  • n/a (should still be set to blank due to existing tablesaw functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@HMS17 HMS17 marked this pull request as ready for review February 20, 2024 19:06
@HMS17 HMS17 requested review from a team, davedrp, dmeidlin and mlm483 and removed request for a team, davedrp and mlm483 February 20, 2024 19:07
@davedrp davedrp self-assigned this Mar 1, 2024
@HMS17 HMS17 merged commit 4a2b1d5 into develop Mar 6, 2024
@HMS17 HMS17 deleted the feature/BI-1993 branch March 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants