Skip to content

BI-2038 BrAPI endpoint overrides for crops and programs to support MrBean#328

Merged
nickpalladino merged 1 commit intodevelopfrom
feature/BI-2038
Jan 23, 2024
Merged

BI-2038 BrAPI endpoint overrides for crops and programs to support MrBean#328
nickpalladino merged 1 commit intodevelopfrom
feature/BI-2038

Conversation

@nickpalladino
Copy link
Member

Description

Story: https://breedinginsight.atlassian.net/browse/BI-2038?atlOrigin=eyJpIjoiODdlMTQ1NmE4MjVhNDUxZWIxYzdkNGRhZjEyYjFjNDIiLCJwIjoiaiJ9

  • Added brapi v2 endpoint overrides for /commoncropnames and /programs

Dependencies

  • None

Testing

  • Verify that /commoncropnames only returns the name of the crop for the programId in the path
  • Verify that /programs only returns the program for the programId in the path and that the program key has been stripped from the name

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@nickpalladino nickpalladino requested review from a team, dmeidlin and mlm483 and removed request for a team January 19, 2024 22:41
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working.

@nickpalladino nickpalladino merged commit abe80e1 into develop Jan 23, 2024
@nickpalladino nickpalladino deleted the feature/BI-2038 branch January 23, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants