BI-2014 - unable to download experiment#325
Merged
davedrp merged 2 commits intorelease/0.9from Jan 11, 2024
Merged
Conversation
…ddress legacy data in the future
nickpalladino
approved these changes
Jan 2, 2024
dmeidlin
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BI-2014 - unable to download experiment
Description
Story: IF an experiment was created; with at least one observation variable (ontology) that was missing a "Full Name",
THEN that experiment can not be downloaded.
NOTE: The issue of the Experiment's Phenotypes and Observations are not rendering in Experiment View has not been addressed in this code change.
Change made
Removed some code that was causing the observation variable to be saved without the [program key]. This code was originally added as defensive code that protected against legacy data. That code may no longer be needed.
Dependencies
bi-web: develop
Testing
EXPECTED RESULT
The Experiment is downloaded.
Checklist: