Skip to content

BI-2014 - unable to download experiment#325

Merged
davedrp merged 2 commits intorelease/0.9from
bug/BI-2014
Jan 11, 2024
Merged

BI-2014 - unable to download experiment#325
davedrp merged 2 commits intorelease/0.9from
bug/BI-2014

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented Dec 22, 2023

BI-2014 - unable to download experiment

Description

Story: IF an experiment was created; with at least one observation variable (ontology) that was missing a "Full Name",
THEN that experiment can not be downloaded.

NOTE: The issue of the Experiment's Phenotypes and Observations are not rendering in Experiment View has not been addressed in this code change.

Change made

Removed some code that was causing the observation variable to be saved without the [program key]. This code was originally added as defensive code that protected against legacy data. That code may no longer be needed.

Dependencies

bi-web: develop

Testing

  1. Create an Ontology without a Full Name.
  2. Create an Experiment with the Observation Variable defined in step 1.
  3. Download the Experiment.
    EXPECTED RESULT
    The Experiment is downloaded.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@davedrp davedrp requested review from a team, dmeidlin and nickpalladino and removed request for a team December 22, 2023 20:27
@github-actions github-actions bot added the bug Something isn't working label Dec 22, 2023
@davedrp davedrp marked this pull request as ready for review December 22, 2023 20:52
@davedrp davedrp changed the base branch from develop to release/0.9 January 11, 2024 18:55
@davedrp davedrp merged commit 12270a1 into release/0.9 Jan 11, 2024
@davedrp davedrp deleted the bug/BI-2014 branch January 11, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants