Skip to content

BI-2005 - Expand Exp Template#323

Merged
nickpalladino merged 13 commits intodevelopfrom
feature/BI-2005
Jan 8, 2024
Merged

BI-2005 - Expand Exp Template#323
nickpalladino merged 13 commits intodevelopfrom
feature/BI-2005

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Dec 11, 2023

Description

Story: BI-2005

  • added db migration for new experiment columns
  • added validations for geocoordinates
  • store geocoordinates into observation unit position object
  • updated integration tests to work with changes

Dependencies

Testing

  • Ensure that validations as specified in card work

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@nickpalladino nickpalladino requested review from a team, davedrp and mlm483 and removed request for a team January 4, 2024 16:13
Comment on lines +39 to +41
@Singleton @Replaces(ObjectMapper.class)
@Override
public ObjectMapper objectMapper(@Nullable JacksonConfiguration jacksonConfiguration, @Nullable JsonFactory jsonFactory) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this override be used every time an ObjectMapper is injected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya

Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed developer testing

@nickpalladino nickpalladino merged commit 2214c44 into develop Jan 8, 2024
@nickpalladino nickpalladino deleted the feature/BI-2005 branch January 8, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants