Skip to content

[BI-1965-bugfix] - Fix Localstack And Gigwa Configurations#321

Merged
mlm483 merged 4 commits intodevelopfrom
feature/BI-1965-bugfix
Dec 15, 2023
Merged

[BI-1965-bugfix] - Fix Localstack And Gigwa Configurations#321
mlm483 merged 4 commits intodevelopfrom
feature/BI-1965-bugfix

Conversation

@mlm483
Copy link
Contributor

@mlm483 mlm483 commented Dec 8, 2023

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1965

We have been using localstack/localstack:latest, and the env var we used, EXTERNAL_HOSTNAME, is deprecated.

  • Replaced with the supported LOCALSTACK_HOST env var.

Related PR in bi-docker-stack: Breeding-Insight/bi-docker-stack#37

The error we were seeing with Gigwa not allowing imports from biapi

Dependencies

None

Testing

  1. Functional Test:
    • Checkout this branch git checkout feature/BI-1965-bugfix.
    • Stop your local docker containers.
    • Start your local docker containers. This will pick up the change.
    • Run bi-api and bi-web.
    • Ensure you can upload genotypic data (first upload germplasm, then experiment, then vcf - you have to unzip this).
  2. Ensure unit tests pass

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@mlm483 mlm483 requested review from a team, dmeidlin and nickpalladino and removed request for a team December 8, 2023 22:16
@mlm483 mlm483 merged commit c706664 into develop Dec 15, 2023
@mlm483 mlm483 deleted the feature/BI-1965-bugfix branch December 15, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants