Skip to content

[BI-1960-2] Exp import proceeds with multiple exp names & error message improvement#316

Merged
dmeidlin merged 2 commits intodevelopfrom
feature/BI-1960-2
Dec 6, 2023
Merged

[BI-1960-2] Exp import proceeds with multiple exp names & error message improvement#316
dmeidlin merged 2 commits intodevelopfrom
feature/BI-1960-2

Conversation

@dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Nov 30, 2023

Description

Story: BI-1960

An additional check for multiple unique experiment titles in the same import file was put in place when creating the trial PIO during experiment import. An exception is thrown if multiple exp titles detected.

Dependencies

none

Testing

  1. create an experiment import file containing multiple rows with at least two distinct experiment titles listed: for example, EXP-A and EXP-B.
  2. attempt to import the experiments

A red error banner should appear citing "File contains more than one Experiment Title"

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@dmeidlin dmeidlin changed the title [BI-1960] Exp import proceeds with multiple exp names & error message improvement [BI-1960-2] Exp import proceeds with multiple exp names & error message improvement Dec 1, 2023
@dmeidlin dmeidlin requested review from davedrp and mlm483 December 1, 2023 15:54
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developer Test passed
(PS -- nice logic)

@dmeidlin dmeidlin merged commit 228d6dc into develop Dec 6, 2023
@dmeidlin dmeidlin deleted the feature/BI-1960-2 branch December 6, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants