Skip to content

BI-1921 - Support Field Book Study Import from DeltaBreed#308

Merged
dmeidlin merged 20 commits intorelease/0.9from
feature/BI-1921
Jan 24, 2024
Merged

BI-1921 - Support Field Book Study Import from DeltaBreed#308
dmeidlin merged 20 commits intorelease/0.9from
feature/BI-1921

Conversation

@timparsons
Copy link
Member

@timparsons timparsons commented Nov 6, 2023

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1921

Please include a summary of the change that was made.

Dependencies

bi-web/feature/BI-1921

Testing

Please include any details needed for reviewers to test this code

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@timparsons timparsons force-pushed the feature/BI-1921 branch 2 times, most recently from 1cefd2a to a2dee52 Compare November 30, 2023 21:10
@timparsons timparsons marked this pull request as ready for review November 30, 2023 21:11
@timparsons timparsons requested review from a team, dmeidlin and mlm483 and removed request for a team November 30, 2023 21:12
mlm483
mlm483 requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmeidlin I have a few questions and change requests. I'd also like to run TAF before merging. Functional testing and our unit/integration tests revealed no issues.

dmeidlin
dmeidlin requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@dmeidlin dmeidlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlm483 I've left my initial review comments and ready to discuss.

@dmeidlin dmeidlin changed the base branch from develop to release/0.9 January 24, 2024 15:26
timparsons and others added 16 commits January 24, 2024 10:32
@timparsons @dmeidlin
[BI-1921] Adding OIDC endpoints
30518ea 
Stubbed out methods needed for Field Book to fetch data
@timparsons @dmeidlin
[BI-1921] fixing compilation error
6e49ae2
@timparsons @dmeidlin
[BI-1921] Implementing various BrAPI endpoints to support Field Book
468ea83
@timparsons @dmeidlin
[BI-1921] Fixing trait fetch bug
d34d5b1
@timparsons @dmeidlin
[BI-1921] filtering out REP and BLOCK levels from the /observationlev…
3c45369 
…els response
@timparsons @dmeidlin
[BI-1921] Updating trait response to have the trait name be the first…
9c53b63 
… synonym

Apps like Field Book use the first synonym as the displayed name of the synonym
@timparsons @dmeidlin
[BI-1921] fixing compilation error
c089de8
@timparsons @dmeidlin
[BI-1921] fixing failing unit tests
9cc4350 
- Adding new unit tests for new BrAPI endpoints
- reorganizing BrAPI DAOs to be in more appropriate package
@timparsons @dmeidlin
[BI-1921] fixing unit tests
42ea0c1
@timparsons @dmeidlin
[BI-1921] adding more unit tests
2f3309f
@timparsons @dmeidlin
[BI-1921] cleaning up imports
2769cf3
@timparsons @dmeidlin
[BI-1921] fixing compilation errors
5968eca
@dmeidlin
prepend serverinfo path with biapi version number
16e1f2b
@dmeidlin
remove redundant query variables
5ce6f19
@dmeidlin
move helper methods to trait service
9f9b142
@dmeidlin
remove vestigial comments
f408da3
@dmeidlin dmeidlin merged commit f882017 into release/0.9 Jan 24, 2024
@dmeidlin dmeidlin deleted the feature/BI-1921 branch January 24, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmeidlin dmeidlin dmeidlin approved these changes

@mlm483 mlm483 mlm483 approved these changes

Assignees

@dmeidlin dmeidlin

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timparsons @dmeidlin @mlm483