Skip to content

BI-1910 - Allow Breeder to Upload a Genotype Sample File#306

Merged
timparsons merged 13 commits intodevelopfrom
feature/BI-1910
Nov 29, 2023
Merged

BI-1910 - Allow Breeder to Upload a Genotype Sample File#306
timparsons merged 13 commits intodevelopfrom
feature/BI-1910

Conversation

@timparsons
Copy link
Member

@timparsons timparsons commented Oct 30, 2023

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1910

Defined new endpoints for creating and managing sample submissions including:

  • Ability upload a new sample submission
  • Ability to fetch submissions within a program
  • Ability to fetch an individual submission
  • Ability to update the status of a submission
  • Ability to automatically submit an order to a vendor

Dependencies

Testing

See testing instructions in Breeding-Insight/bi-web#343

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: https://github.com/Breeding-Insight/taf/actions/runs/6765876438

@timparsons timparsons marked this pull request as ready for review November 6, 2023 15:34
@timparsons timparsons requested review from a team, davedrp and nickpalladino and removed request for a team November 6, 2023 15:34
var legalGermplasmName = germplasm.getDefaultDisplayName().replaceAll(SAMPLE_NAME_ILLEGAL_CHARS_REGEX, "_");
String name = String.format(SAMPLE_NAME_FORMAT, legalGermplasmName, plate.getPlateName(), row, Integer.parseInt(column));

if(name.length() > 100) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the significance of length 100?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickpalladino This is a DArT restriction

@Client("/${micronaut.bi.api.version}")
private RxHttpClient client;

// private final Gson gson = new GsonBuilder().registerTypeAdapter(OffsetDateTime.class, (JsonDeserializer<OffsetDateTime>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this I think

@timparsons timparsons merged commit aa58fd3 into develop Nov 29, 2023
@timparsons timparsons deleted the feature/BI-1910 branch November 29, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants