Conversation
dmeidlin
approved these changes
Oct 30, 2023
timparsons
approved these changes
Nov 6, 2023
Changed the wording from 'integers' to 'digits'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BI-1914 - Improve exp dataset sort
Added two methods to sort the dataset:
sortDefaultForObservationUnit()- called by getDatasetData() to sort the datset as displayed on the Experiment detail page.sortDefaultForExportRows()- called by exportObservations() to sort the dataset for the Experiment download.ALSO
The sheet-name of an downloaded Excel experiment is now "Data" instead of "Experiment Data" see BI-1583
Dependencies
bi-web: feature/BI-1914 branch
Testing
go to the Experiment detail page
the default order should be by
Envand thenExp Unit IdDownload an experiment
the order of the downloaded file(s) should be by
Envand thenExp Unit IdChecklist: