BI-1900 - Update Validation Error Messages#302
Merged
mlm483 merged 3 commits intorelease/0.8.1from Oct 30, 2023
Merged
Conversation
timparsons
requested changes
Oct 17, 2023
Member
timparsons
left a comment
There was a problem hiding this comment.
One small change to a method name, but otherwise looks good!
| public abstract class BrAPIImportService { | ||
| public String getImportTypeId() {return null;} | ||
| public BrAPIImport getImportClass() {return null;} | ||
| public String getWrongDataTypeMsg(String columnName) { |
Member
There was a problem hiding this comment.
I think this method name should be changed to something like getInvalidIntegerMsg
dmeidlin
approved these changes
Oct 20, 2023
timparsons
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-1900
Because we'll need to provide different error messages for different import types, I moved the generic/default error messages to the
BrAPIImportServiceabstract base class (thanks Tim!), and inheritors can override.See the comments on the Jira story for more context.
Dependencies
bi-web/release/0.8.1
Testing
Test editing template-defined column headers in an experiment and observation file and uploading, ensure the displayed error message contains "Column heading does not match template or ontology".
Checklist: