BI-1890 - Experimental Test/Check Improvement#299
Merged
Conversation
mlm483
approved these changes
Oct 10, 2023
dmeidlin
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BI-1890 - Experimental Test/Check Improvement
The main change was the addition of the method
validateTestOrCheck(). All of the other changes in the file where to address "problems" identified by InelliJ. (the fist commit address the functionality, the second commit address the "problems".Dependencies
bi-web: develop branch
Testing
Import an experiment with the values of the
Test (T) or Check (C)column being a combination of:Expected Outcome
One error message for each invalid value, listed in the error table.
Checklist: