Skip to content

BI-1890 - Experimental Test/Check Improvement#299

Merged
davedrp merged 3 commits intodevelopfrom
feature/BI-1890-2
Oct 13, 2023
Merged

BI-1890 - Experimental Test/Check Improvement#299
davedrp merged 3 commits intodevelopfrom
feature/BI-1890-2

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented Oct 6, 2023

Description

BI-1890 - Experimental Test/Check Improvement

The main change was the addition of the method validateTestOrCheck(). All of the other changes in the file where to address "problems" identified by InelliJ. (the fist commit address the functionality, the second commit address the "problems".

Dependencies

bi-web: develop branch

Testing

Import an experiment with the values of the Test (T) or Check (C) column being a combination of:

  • Valid Values - ['T', 'test' (any case combination), 'C', 'check'(any case combination), or <BLANK>]
  • Invalid Values - [anything else (Examples: 'Tests', '(C)', 'bob']

Expected Outcome
One error message for each invalid value, listed in the error table.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: https://github.com/Breeding-Insight/taf/actions/runs/6433568052

@davedrp davedrp requested review from a team, dmeidlin and mlm483 and removed request for a team October 6, 2023 15:25
@davedrp davedrp marked this pull request as ready for review October 6, 2023 19:15
@davedrp davedrp merged commit ebb5127 into develop Oct 13, 2023
@davedrp davedrp deleted the feature/BI-1890-2 branch October 13, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants