Skip to content

BI-1872 - Generate Access Token for using BrAPI with DeltaBreed#289

Merged
timparsons merged 3 commits intodevelopfrom
feature/BI-1872
Sep 5, 2023
Merged

BI-1872 - Generate Access Token for using BrAPI with DeltaBreed#289
timparsons merged 3 commits intodevelopfrom
feature/BI-1872

Conversation

@timparsons
Copy link
Member

@timparsons timparsons commented Aug 30, 2023

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1872

expanded the TokenController#apiToken method to allow the generation of a token to be triggered from the UI (previously this method was only used for generating a token for Field Book)

Dependencies

none

Testing

See Breeding-Insight/bi-web#327

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: https://github.com/Breeding-Insight/taf/actions/runs/6027686471

…rDescription on how to use BrAPI with DeltaBreed
…frontend to use it to generate a token for a user
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

serverInfo.setServerName("DeltaBreed");
serverInfo.setContactEmail("bidevteam@cornell.edu");
serverInfo.setOrganizationURL("breedinginsight.org");
serverInfo.setServerDescription("BrAPI endpoints are not implemented at the root of this domain. Please make BrAPI calls in the context of a program (ex: https://app.breedinginsight.net/v1/programs/<programId>/brapi/v2)");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timparsons timparsons merged commit 9b975e4 into develop Sep 5, 2023
@timparsons timparsons deleted the feature/BI-1872 branch September 5, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants