BI-1880 - Error saving experiment import with Breedbase#287
Merged
Conversation
dmeidlin
approved these changes
Aug 28, 2023
davedrp
approved these changes
Sep 7, 2023
Contributor
davedrp
left a comment
There was a problem hiding this comment.
Passed Developer Testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-1880
BreedBase refreshes materialized views after each POST request, so increasing the post-group-size from 100 to 1000 could reduce the number of refreshes and improve performance. I also added support for setting this value from a new environment variable
POST_CHUNK_SIZE(added to .env.template).I also snuck in some changes to docker-compose.yml which is helpful in development.
Testing
Upload large files, see if the chunk size is increased. The default value will be 1000 now, but you can also set a value in your .env.
Ultimately, once this is deployed we'll re-run the workflow documented on the Jira card to see if it's able to complete successfully.
Checklist: