BI-1842 - Append existing exp with observations isn't working#273
Merged
timparsons merged 2 commits intorelease/0.8from Jul 24, 2023
Merged
BI-1842 - Append existing exp with observations isn't working#273timparsons merged 2 commits intorelease/0.8from
timparsons merged 2 commits intorelease/0.8from
Conversation
…ror if there is an existing observation, and a new upload has a blank value for the observationUnit/Phenotype.
dmeidlin
approved these changes
Jul 19, 2023
mlm483
reviewed
Jul 19, 2023
…ting data Added more metadata to the creation of an observation to track when/who created it and define an external reference id
mlm483
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Story: https://breedinginsight.atlassian.net/browse/BI-1842
Loosened the validation of observations to only throw an error if a new upload will change the value of an existing observation. If the incoming value is blank, then no validation error will be thrown.
Dependencies
None
Testing
Upload an experiment with observations
Upload a file to the same experiment with new observations to a different phenotype/trait. Ensure that the observations from the first upload are blank in the second file
Ensure the file uploads successfully
Upload an experiment with observations
Upload a file to the same experiment with new observations to a different phenotype/trait. Ensure that the observations from the first upload are copied from the first file to the second file
Ensure the file uploads successfully
Upload an experiment with observations
Upload a file to the same experiment with new observations to a different phenotype/trait. Also put new values for the existing observations
Ensure the file upload throws a validation error for the existing observations attempting to be overwritten
Checklist: