Skip to content

BI-1842 - Append existing exp with observations isn't working#273

Merged
timparsons merged 2 commits intorelease/0.8from
bug/BI-1842
Jul 24, 2023
Merged

BI-1842 - Append existing exp with observations isn't working#273
timparsons merged 2 commits intorelease/0.8from
bug/BI-1842

Conversation

@timparsons
Copy link
Member

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1842

Loosened the validation of observations to only throw an error if a new upload will change the value of an existing observation. If the incoming value is blank, then no validation error will be thrown.

Dependencies

None

Testing

  1. Upload an experiment with observations

  2. Upload a file to the same experiment with new observations to a different phenotype/trait. Ensure that the observations from the first upload are blank in the second file

  3. Ensure the file uploads successfully

  4. Upload an experiment with observations

  5. Upload a file to the same experiment with new observations to a different phenotype/trait. Ensure that the observations from the first upload are copied from the first file to the second file

  6. Ensure the file uploads successfully

  7. Upload an experiment with observations

  8. Upload a file to the same experiment with new observations to a different phenotype/trait. Also put new values for the existing observations

  9. Ensure the file upload throws a validation error for the existing observations attempting to be overwritten

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

…ror if there is an existing observation, and a new upload has a blank value for the observationUnit/Phenotype.
@timparsons timparsons requested review from a team, dmeidlin and mlm483 and removed request for a team July 18, 2023 19:49
@github-actions github-actions bot added the bug Something isn't working label Jul 18, 2023
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upload succeeds or fails in the correct cases, however I'm not seeing any details when it fails, just "An unknown error has occurred when processing your import". Is that expected?
image

…ting data

Added more metadata to the creation of an observation to track when/who created it and define an external reference id
@timparsons timparsons requested a review from mlm483 July 24, 2023 15:49
@timparsons timparsons merged commit 97cd869 into release/0.8 Jul 24, 2023
@timparsons timparsons deleted the bug/BI-1842 branch July 24, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants