[BI-1825] add check for legacy trait names in ExperimentProcessor#270
Merged
dmeidlin merged 2 commits intorelease/0.8from Jul 7, 2023
Merged
[BI-1825] add check for legacy trait names in ExperimentProcessor#270dmeidlin merged 2 commits intorelease/0.8from
dmeidlin merged 2 commits intorelease/0.8from
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1825
Update dExperimentProcessor::addObsVarsToDatasetDetails (GitHub link) to check if the Trait.fullName field is populated, and if so, then append the program key, otherwise don’t.
Dependencies
testing needs to be done with a program connected to a brapi service using legacy trait names
Testing
To test, upload an experiment with phenotypic data that uses Traits that are defined in BreedBase without program key namespacing.
Checklist: