Skip to content

[BI-1825] add check for legacy trait names in ExperimentProcessor#270

Merged
dmeidlin merged 2 commits intorelease/0.8from
bug/BI-1825-1
Jul 7, 2023
Merged

[BI-1825] add check for legacy trait names in ExperimentProcessor#270
dmeidlin merged 2 commits intorelease/0.8from
bug/BI-1825-1

Conversation

@timparsons
Copy link
Member

Description

Story: BI-1825

Update dExperimentProcessor::addObsVarsToDatasetDetails (GitHub link) to check if the Trait.fullName field is populated, and if so, then append the program key, otherwise don’t.

Dependencies

testing needs to be done with a program connected to a brapi service using legacy trait names

Testing

To test, upload an experiment with phenotypic data that uses Traits that are defined in BreedBase without program key namespacing.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Jul 6, 2023
@dmeidlin dmeidlin merged commit d75a7bc into release/0.8 Jul 7, 2023
@dmeidlin dmeidlin deleted the bug/BI-1825-1 branch July 7, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants