Skip to content

[BI-1819] Experimental download file: phenotypes are out of order#266

Merged
dmeidlin merged 2 commits intodevelopfrom
feature/BI-1819
Jun 30, 2023
Merged

[BI-1819] Experimental download file: phenotypes are out of order#266
dmeidlin merged 2 commits intodevelopfrom
feature/BI-1819

Conversation

@dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Jun 20, 2023

Description

Story: BI-1819

A reference to the import upload was added to the signature of the interface method Processor::process so that the order of the dynamic columns in the import file can be used when creating a new observation dataset.

TrialService::exportObservations was updated to use the order of the names in the observation dataset obs var list returned from the brapi service when creating the dynamic columns for export.

Dependencies

none

Testing

  1. using the deltabreed ui, upload an experiment containing multiple Observation Variable columns with or without observation data.
  2. verify that the order of the obs var columns matches the order in the import file
  3. import the experiment
  4. go to the Experiment&Observations table and click Download for the new experiment
  5. verify the order of the obs var columns in the downloaded file matches those in the original import file.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@dmeidlin dmeidlin marked this pull request as ready for review June 20, 2023 15:14
@dmeidlin dmeidlin requested review from a team, nickpalladino and timparsons and removed request for a team June 20, 2023 15:14
Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dmeidlin dmeidlin merged commit 5e3311c into develop Jun 30, 2023
@dmeidlin dmeidlin deleted the feature/BI-1819 branch June 30, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants