Skip to content

[BI-1456] Ontology Share - Improvement#261

Merged
dmeidlin merged 1 commit intodevelopfrom
feature/BI-1456
Jun 12, 2023
Merged

[BI-1456] Ontology Share - Improvement#261
dmeidlin merged 1 commit intodevelopfrom
feature/BI-1456

Conversation

@dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Jun 9, 2023

Description

Story: BI-1456

OntologyService::getSharedOntology was updated to filter out from the list of sharable programs any programs currently sharing with each other.

Dependencies

none

Testing

  • create three test programs A, B, and C
  • import ontology into A and C but not B
  • Have A share its ontology with B but do not have B accept
  • Go to the Configuration tab of C and click "Share Ontology"
  • verify that programs A is not present but B is present in the list of programs
  • got to the configuration tab of B and accept sharing with A
  • Go to the configuration tab of C and click "Share Ontology"
  • verify neither A nor B are present in the list

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@dmeidlin dmeidlin requested review from a team, mlm483 and nickpalladino and removed request for a team June 9, 2023 19:57
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmeidlin dmeidlin merged commit c31c2d2 into develop Jun 12, 2023
@dmeidlin dmeidlin deleted the feature/BI-1456 branch June 12, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants