Description

Story: https://breedinginsight.atlassian.net/browse/BI-1803

NOTE: import code for Ontology, Germplasm and Experiments & Observations will eventually be unified, see https://breedinginsight.atlassian.net/browse/BI-1796, but for now Ontology has it's own file parsing methods, etc., which is why this bug is specific to Ontology.

Empty or null rows in Excel or CSV files were causing errors during Ontology upload.
To fix this, the ExcelParser::parse method now drops empty and null rows.

For Excel files, the empty cells are null whereas for CSV they are empty strings (""). Because ExcelParser::parse is used by both Excel and CSV imports, I made sure to handle both situations.

I added unit tests and .xls, .xlsx and .csv test files.

Testing

Example test files below, you can make your own by clearing rows in an Excel file and saving as .xls, .xlsx, .csv.

BI-1803 6 Phenos Ontology -row height changed.csv
BI-1803 6 Phenos Ontology -row height changed.xls

Checklist:

• I have performed a self-review of my own code
• I have tested my code and ensured it meets the acceptance criteria of the story
• I have tested that my code works with both the brapi-java-server and BreedBase
• I have create/modified unit tests to cover this change
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to documentation
• I have run TAF: https://github.com/Breeding-Insight/taf/actions/runs/5126403136