Skip to content

[BI-1193] addressed bug in BI-1193#256

Merged
dmeidlin merged 1 commit intodevelopfrom
bug/BI-1193
May 26, 2023
Merged

[BI-1193] addressed bug in BI-1193#256
dmeidlin merged 1 commit intodevelopfrom
bug/BI-1193

Conversation

@dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented May 26, 2023

Description

BI-1193

The order that new Trials and dataset Lists are posted was changed from first-Trial-then-List to first-List-then-Trial to prevent the case where a network interruption would result in a Trial saved to the db containing a reference to a dataset List that was never created.

Dependencies

none

Testing

same as card and PR for BI-1193

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label May 26, 2023
@dmeidlin dmeidlin merged commit e564fa0 into develop May 26, 2023
@dmeidlin dmeidlin deleted the bug/BI-1193 branch May 26, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants