Conversation
|
I ran TAF to be safe: https://github.com/Breeding-Insight/taf/actions/runs/5126064698 |
Thanks! |
mlm483
left a comment
There was a problem hiding this comment.
The Pedigree viewer looks good for Germplasm with an unknown parent specified by entry number 0 in the uploaded file! However, the Jira story suggests the Germplasm export file should also contain the 0 entry number (or maybe GID? - I'm unclear).
"Expect: the germplasm download to include Unknown GID 0 like observed in the pedigree tree and in the original import file. Notice that Mahan is the result of biparental cross (Schley/Unknown)." - https://breedinginsight.atlassian.net/browse/BI-1798
Can we discuss tomorrow?
src/main/java/org/breedinginsight/brapi/v2/services/BrAPIGermplasmService.java
Show resolved
Hide resolved
src/main/java/org/breedinginsight/brapi/v2/services/BrAPIGermplasmService.java
Show resolved
Hide resolved
Updated to handle 0's the parent entry numbers. Included logging statements in case additionalinfo is missing properties we're expecting we can more easily figure out why. I don't think we have production data that would fail this but just in case. |
mlm483
left a comment
There was a problem hiding this comment.
Looks good, I think exported data now matches imported data as closely as possible.
I wanted to make sure this is expected behavior for empty parent entry numbers. As long as this behavior is expected, I say go ahead and merge 🚀.
| Has Female Parent Entry No. | Empty Female Parent Entry No. | |
|---|---|---|
| Has Male Parent Entry No. | Upload Succeeds ✅ | "Female parent is missing..." error message ❌ (first screenshot) |
| Empty Male Parent Entry No. | Upload Succeeds ✅ (second screenshot) | Upload Succeeds ✅ |


Description
Story: https://breedinginsight.atlassian.net/browse/BI-1798?atlOrigin=eyJpIjoiNjU0OWI5OTNmZmRhNDA1Y2JmZjllZDQzOWM4YTQxNTAiLCJwIjoiaiJ9
Dependencies
Testing
Checklist: