Merged
Conversation
timparsons
requested changes
May 24, 2023
src/main/java/org/breedinginsight/brapi/v2/services/BrAPITrialService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/breedinginsight/brapps/importer/daos/BrAPITrialDAO.java
Outdated
Show resolved
Hide resolved
src/main/java/org/breedinginsight/brapi/v2/ExperimentController.java
Outdated
Show resolved
Hide resolved
timparsons
approved these changes
May 24, 2023
Member
timparsons
left a comment
There was a problem hiding this comment.
Just a couple of very minor things. Approving assuming they will be addressed.
|
|
||
| import javax.inject.Inject; | ||
| import javax.validation.Valid; | ||
| import java.util.HashMap; |
Member
There was a problem hiding this comment.
This import statement isn't needed
| } | ||
| return trial; | ||
| } catch (ApiException e) { | ||
| throw new InternalServerException(e.getMessage(), e); |
Member
There was a problem hiding this comment.
Could you add a error log message here. You can use Utilities#generateApiExceptionLogMessage to generate a log message from the ApiException object.
dmeidlin
approved these changes
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1716 Sub-story of BI-1644 View experiment: Details, Summary Stats, Actions
Dependencies
bi-web: feature/BI-1717 branch
Testing
(See Acceptance Criteria in BI-1644)
Checklist: