Skip to content

BI-1781#253

Merged
nickpalladino merged 2 commits intorelease/0.8from
bug/BI-1781
Jun 30, 2023
Merged

BI-1781#253
nickpalladino merged 2 commits intorelease/0.8from
bug/BI-1781

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented May 11, 2023

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1781?atlOrigin=eyJpIjoiOWMxZjNmMzJlOWVhNDA0MzlmNThiNDlhYTI2NmJlMGYiLCJwIjoiaiJ9

  • Added flag for disabling brapi test server auth
  • Fix for unknown germplasm when germplasm ids are UUIDs

Dependencies

Testing

  • See brapi test server card

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label May 11, 2023
@nickpalladino nickpalladino requested review from a team, davedrp, mlm483 and timparsons and removed request for a team and davedrp June 5, 2023 20:41
@nickpalladino nickpalladino changed the base branch from develop to release/0.8 June 30, 2023 14:43
@nickpalladino nickpalladino merged commit 12af9cf into release/0.8 Jun 30, 2023
@nickpalladino nickpalladino deleted the bug/BI-1781 branch June 30, 2023 15:01
@nickpalladino nickpalladino restored the bug/BI-1781 branch June 30, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants